Dan Hecht has posted comments on this change.
Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of
Impala LZO.
......................................................................
Patch Set 7:
> If libimpalalzo.so is not a valid file in ${IMPALA_LZO}/build --
> for any reason -- LZO tests will be skipped.
>
> Are you proposing that we log something more verbose as to why the
> tests are being skipped? Or do you have a better criteria for
> determining whether the tests should be skipped in the first place?
I wasn't proposing a solution, but asking if this is a risk we should worry
about (risk of silently losing test coverage). Or are we confident that that
won't happen?
--
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No
