Hello Michael Brown, Internal Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3782
to look at the new patch set (#8).
Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of
Impala LZO.
......................................................................
IMPALA-3898: Add a pytest skipif decorator based on presence of Impala
LZO.
As part of shoring up the build/test procedure for the ASF initiative,
if Impala LZO isn't present, we want to skip tests that would otherwise
fail without it. Rather than adding a bunch of pytest skip decorators
to existing tests, instead just create an autouse fixture in the
pytest conftest.py file. This fixture will automatically always get
invoked with any test, and in case that ${IMPALA_LZO} is not defined,
it will skip tests if the test vector contains compression_codec: lzo.
This patch also removes IMPALA_LZO from bin/impala-config.sh. Users
will need to set this env variable themselves in order to build or
test Impala with Impala LZO support.
There is one query in data_errors (test_hdfs_scan_node_errors) that
will always fail without Impala LZO, regardless of codec, so it was
moved to a separate test, and in that one instance, a skipif decorator
was added.
Also, minor PEP-8 improvements were made in various files.
Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
---
M bin/impala-config.sh
A
testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-lzo-node-errors.test
M
testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
M tests/common/environ.py
M tests/conftest.py
5 files changed, 55 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/3782/8
--
To view, visit http://gerrit.cloudera.org:8080/3782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
