Tim Armstrong has posted comments on this change. Change subject: IMPALA-3936: BufferedBlockMgr fixes for Pin() while write in flight. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3832/2//COMMIT_MSG Commit Message: Line 28: It succeeded. > I'm fine with the unit test coverage, but just thinking that if this worklo Agreed, I think it's timing-dependent though so I couldn't see a way to make it reproducible - I think the main thing would be to run the stress test on a variety of data sizes and hardware configs. I plan to port many of the BufferedBlockMgr unit tests to the new buffer pool so we should have coverage of this interesting sequence of operations. -- To view, visit http://gerrit.cloudera.org:8080/3832 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4be4fad8e6f2303db19ea1e2bd0f13523781ae8e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
