Marcel Kornacker has posted comments on this change. Change subject: PREVIEW: IMPALA-2550 Introduce query-wide execution context. ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3817/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS4, Line 418: // TODO: Should we create a QueryExecState for the coordinator fragment? > I thought the coordinator does not have a QEM (or previously a FragmentMgr) for the sake of keeping this patch small, it's probably a good idea to leave out the restructuring of the coordinator (plus, this has lots of conflicts with my next set of mt-related changes) http://gerrit.cloudera.org:8080/#/c/3817/4/be/src/runtime/fragment-exec-state.h File be/src/runtime/fragment-exec-state.h: Line 77: // TODO: make pointer to shared per-query state remove, unless there's something to do http://gerrit.cloudera.org:8080/#/c/3817/4/be/src/service/query-exec-mgr.h File be/src/service/query-exec-mgr.h: PS4, Line 80: GetQueryExecStateFromFragmentId > As we spoke everything coming in to a backend specifies only the fragment_i we can also encode the instance id as query id + instance offset/instance number. that way we can build static arrays, indexed by instance number, that live in the qes. Line 91: class ScopedQueryExecStateRef { > Done please find a more concise name (maybe take inspiration from 'lock_guard'?) -- To view, visit http://gerrit.cloudera.org:8080/3817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I892091d6401acb2ea91ccb1623af54c6f9635e6c Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
