Tim Armstrong has posted comments on this change. Change subject: Remove dead and untested code ......................................................................
Patch Set 1: I did manually verify that the functions didn't have any callsites, so I'm convinced it's actually dead. Building with shared objects doesn't work for me, but it hasn't worked for me since I upgraded to Ubuntu 5.10 I only build with gold, but we should get some coverage in the GVO. -- To view, visit http://gerrit.cloudera.org:8080/3989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49c27cbfef03ef97befa9a607b3d8d7ac6e22a43 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
