Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3938/3/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: Line 216: file_group_(file_group), Is it possible for file_group to be NULL here? Add a DCHECK? PS3, Line 225: file_group_ != NULL Is this check necessary? file_group_ should be non-NULL always, right? http://gerrit.cloudera.org:8080/#/c/3938/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: Line 112: /// responsible for calling the Close method to delete all the files in the group. > Done There were several more comments further down in the file too. http://gerrit.cloudera.org:8080/#/c/3938/3/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: Line 143: ~FileGroup(){ Nit: we normally put it after the constructor. Best to be consistent so it's easy to find. Line 154: boost::ptr_vector<File> tmp_files_; I'm ok with leaving as-is, since this is carried over from BufferedBlockMgr and should work fine. Other reviewers may ask you to change this to vector<unique_ptr> would be more consistent with the rest of the codebase. -- To view, visit http://gerrit.cloudera.org:8080/3938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e9039ad1c0df978ab71b956af33fd997714e73 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
