Tim Armstrong has posted comments on this change. Change subject: IMPALA-3090: always log memory limit errors ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4049/1/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: PS1, Line 350: int64_t failed_allocation) > Thanks for adding the comment. It may be worth setting the default value of Done http://gerrit.cloudera.org:8080/#/c/4049/1/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: PS1, Line 245: failed_allocation_size > default = 0? All callsites provide the argument so I don't think it's necessary. -- To view, visit http://gerrit.cloudera.org:8080/4049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5ec5572b0e26898da352b7e6b11eb01c6edb2e5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
