Alex Behm has posted comments on this change. Change subject: Add functional and targeted perf tests for joins with empty builds ......................................................................
Patch Set 1: (3 comments) thanks for adding these http://gerrit.cloudera.org:8080/#/c/4051/1/testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test File testdata/workloads/functional-query/queries/QueryTest/empty-build-joins.test: Line 179: from alltypes at LEFT ANTI JOIN ( lower case for consistency http://gerrit.cloudera.org:8080/#/c/4051/1/testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test File testdata/workloads/functional-query/queries/QueryTest/single-node-nlj.test: Line 165: set num_nodes=1; not needed since num_nodes is set from the outside already Line 169: where att.int_col = 999 if you think it's insignificant how the empty build is constructed, then you can shrink these queries and make it more obvious that they are empty with something like: select ... alltypes at join (values(0 id) limit 0) e I'm ok with these changes either way -- To view, visit http://gerrit.cloudera.org:8080/4051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a68cafec32011a47c569b254979601237e7f2a5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
