Youwei Wang has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 40: (2 comments) http://gerrit.cloudera.org:8080/#/c/3081/40/be/src/util/bit-util.cc File be/src/util/bit-util.cc: Line 170: const uint8_t* src = reinterpret_cast<const uint8_t*>(source); > If they generate the same assembly, then we don't need the extra template p Hi Jim. The code is revised according to your request. Once that commit issue is resolved, I will upload the new patch right at once. http://gerrit.cloudera.org:8080/#/c/3081/40/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 252: static void ByteSwapScalar(void* dst, const void* src, int len); > our coding standard stipulates that output params go at the end, and i see Greetings, Marcel. If you don't mind, I just want to confirm that you want to revise the previous form from this one: void BitUtil::ByteSwap(void* dest, const void* source, int len) to this one: void BitUtil::ByteSwap(const void* source, int len, void* dest)? [Option A] Or you may want to keep this form: void BitUtil::ByteSwap(void* dest, const void* source, int len), but other related functions implemented in this patch should be revised to the form with output params going at the end? [Option B] I am afraid if you mean option A, we should mofidy all callers of this function BitUtil::ByteSwap through the whole Impala project. So I just guess maybe you mean option B? If so, I can handle it with no extra problem here. Thank you for any possible clarification.:) -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 40 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
