Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait
times
......................................................................
Patch Set 1:
Unless I'm missing something, TotalCpuTime at the fragment level isn't
correctly updated with the user/sys time. It looks like we try to approximate
it with:
int64_t cpu_time = cpu_and_wait_time
- runtime_state_->total_storage_wait_timer()->value()
- runtime_state_->total_network_send_timer()->value()
- runtime_state_->total_network_receive_timer()->value();
But it's not clear that that's accurate.
I agree that we already do the right thing for ScannerThreadsUserTime and
ScannerThreadsSysTime
--
To view, visit http://gerrit.cloudera.org:8080/4052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
Gerrit-HasComments: No
