Tim Armstrong has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4063/1/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: Line 120: StringVal UtilityFunctions::CurrentSid(FunctionContext* ctx) { > This function was requested in the feature request, but I feel that it shou I agree that the function lists in the netezza compatibility JIRAs were not thoroughly vetted, thanks for thinking through this. I think some of the same points apply to current_schema, etc as well - it looks like they may be magic constants too. It seems like having functions with the same name as the magic would make porting queries much easier, even though though would still require modifications, so it might be worth considering. We don't have a UDF to return the current session. Maybe that's a useful piece of functionality too even if it's not exactly the same as Netezza. What do you think? Returning it as a string seems ok to me, since that's how we display it everywhere in the system. -- To view, visit http://gerrit.cloudera.org:8080/4063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5d1009bbf42acc175a942d2df484e1c64822ca Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
