Tim Armstrong has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4064/1/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 341: RETURN_IF_ERROR(CommitRows(row_batch, num_row_to_commit)); > I believe it's calling HdfsParquetScanner::CommitRows() which doesn't call Ah you're right. This is confusing. -- To view, visit http://gerrit.cloudera.org:8080/4064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826061a2be10fd0528ca4dd1e97146e3cb983370 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
