Marcel Kornacker has posted comments on this change. Change subject: REVIEW-ONLY: the results of running clang-format ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4046/1/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: Line 261 > Setting BreakBeforeBinaryOperators to NonAssignment or All fixes this, but what exactly does BreakBeforeBinaryOperators do? can you limit the scope to logical operators and boolean exprs? Line 1038: **next_backend_on_host) != backends_on_host.end()); > I think it is ContinuationIndentWidth - 4 spaces, plus the length of the gr shouldn't it be one or the other? i don't recall seeing this before. -- To view, visit http://gerrit.cloudera.org:8080/4046 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00bcdb7957ec55a3b8568887de161b7f30d58de Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
