Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3999: Embed the query-wide fragment instance index in the instance id ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4065/2//COMMIT_MSG Commit Message: PS2, Line 7: 3999 > nit: please use 3988; 3999 is a duplicate. Done PS2, Line 9: This adds utility function in uid-util.h to create query and instance ids and convert between them. : It also adapts SimpleScheduler to utilize those functions when creating the instance id : (TPlanFragmentInstanceCtx.fragment_instance_id). > Long lines. this is a weird line limit, where did this come from? http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: PS2, Line 512: CreateInstanceId(schedule->query_id(), instance_idx, &instance_id); > not clear that you really need this instead of just keeping a TUniqueId and this way it's easier to change the layout, if that should ever be needed. and i don't see any downside. http://gerrit.cloudera.org:8080/#/c/4065/2/be/src/util/uid-util.h File be/src/util/uid-util.h: PS2, Line 62: void > why not return TUniqueId? Easier to use inline. we typically only return scalars PS2, Line 69: void > again, why not return? see above http://gerrit.cloudera.org:8080/#/c/4065/2/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 257: // The bottom NUM_FRAGMENT_INSTANCE_IDX_BITS are 0. > refer to where this is defined Done -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia56a03ed9a1d7e77c72b66a01cd48c5b6bf3624f Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
