Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3832: test invalid data handling in lzo text scanner
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4096/2/tests/query_test/test_scanners_fuzz.py
File tests/query_test/test_scanners_fuzz.py:

Line 61:       pytest.skip()
> why?
We don't have decimal_tbl for these file formats. Added comment.


Line 144:               table_format.compression_codec != 'none'):
> what errors do we produce?
Good point.  I see a lot of:

   Error while reading index file: 
hdfs://localhost:20500/test-warehouse/test_fuzz_alltypes_c35099ab.db/alltypes/year=2010/month=2/000022_0.lzo.index

Updated comment


-- 
To view, visit http://gerrit.cloudera.org:8080/4096
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib707014c1fcfb80cb8076f644fc2b62a5ae758d7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to