Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4009: qgen: add documentation for installing Oracle as ref database ......................................................................
Patch Set 1: (1 comment) I performed the steps (with the docker instructions), and it all works, modulo the few things specific to my environment that instructions like these can't really anticipate. http://gerrit.cloudera.org:8080/#/c/4095/1/tests/comparison/ORACLE.txt File tests/comparison/ORACLE.txt: Line 68: 1. Refer to the instant-client installation instructions. As of this I'm confused by the structure here, since these instructions are referring to the same step as the "1. Get Oracle instant-client" above. I get that its "pre-reqs" vs. "installation instructions", but I think it would be clearer if there was just one ordered list of instructions, with installing the pre-reqs as the first couple of bullet points. -- To view, visit http://gerrit.cloudera.org:8080/4095 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3bf84b7afa8851c49a8d0f0a1ceded94f4de158 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
