Kathy Sun has posted comments on this change. Change subject: System Database (preview for frontend) ......................................................................
Patch Set 9: (6 comments) I change the names and re-upload the test file. http://gerrit.cloudera.org:8080/#/c/3863/6/fe/src/main/java/com/cloudera/impala/planner/InfoSchemaScanNode.java File fe/src/main/java/com/cloudera/impala/planner/InfoSchemaScanNode.java: > Let's clean up the formatting in this file before getting others to review Done PS6, Line 42: > discuss offline Done PS6, Line 45: > Needs updating Done Line 71 > Add a TODO to have one scan range per backend (so other reviewers can see w Done http://gerrit.cloudera.org:8080/#/c/3863/6/fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java File fe/src/main/java/com/cloudera/impala/planner/SingleNodePlanner.java: PS6, Line 1256: table instanceof > Let's do some cleanup here by changing this to 'table'. I was confused why Done http://gerrit.cloudera.org:8080/#/c/3863/6/testdata/workloads/functional-planner/queries/PlannerTest/info-schema.test File testdata/workloads/functional-planner/queries/PlannerTest/info-schema.test: > When I open this file locally there are a bunch of nonsense characters. I t Done -- To view, visit http://gerrit.cloudera.org:8080/3863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adbeb45220c468e43b424d70c30b952f6cec2cd Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <[email protected]> Gerrit-Reviewer: Kathy Sun <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
