Michael Brown has posted comments on this change. Change subject: IMPALA-4001: qgen: add proof of concept tests for Query() objects ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4081/2/tests/comparison/tests/query_object_testdata.py File tests/comparison/tests/query_object_testdata.py: Line 70: testid='select col from table', > A minor followup thought -- it might be nice to have testid as the first el Done -- To view, visit http://gerrit.cloudera.org:8080/4081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ed1960430ae0af469986e33f88aecb6fa74e999 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
