Tim Armstrong has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata ......................................................................
Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/4063/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2787: results[session][query] = GetValue("current_sid()", TYPE_STRING); Can you check that current_session() == current_sid() here? http://gerrit.cloudera.org:8080/#/c/4063/2/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: Line 551: [['user', 'session_user'], 'STRING', [], 'impala::UtilityFunctions::User'], > The PDF attachment of the feature request contained this definition: Yeah, that PDF I think is not 100% accurate. -- To view, visit http://gerrit.cloudera.org:8080/4063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b5d1009bbf42acc175a942d2df484e1c64822ca Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-HasComments: Yes
