Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4127

to look at the new patch set (#2).

Change subject: Stricter clang-format: set DerivePointerAlignment to false.
......................................................................

Stricter clang-format: set DerivePointerAlignment to false.

The description of DerivePointerAlignment, which is set to true in the
Google style, is

   If true, analyze the formatted file for the most common alignment
   of & and *. PointerAlignment is then used only as fallback.

(PointerAlignment is Left, meaning "char* x".)

The virtue of setting DerivePointerAlignment to false is that it will
prevent new contributors from setting the pointers in the wrong place
in a new file or in a file they are modifying heavily.

Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6
---
M .clang-format
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/4127/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I713cdd68af741c7cba9e2c5704f20b8901c9e5f6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to