Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool ......................................................................
Patch Set 7: (1 comment) Added reservation counters and reporting, plus simplified the linkage between the two hierarchies a little by assuming limit checks only happen at the top level. http://gerrit.cloudera.org:8080/#/c/3993/7/be/src/bufferpool/buffer-pool.h File be/src/bufferpool/buffer-pool.h: Line 234: const int64_t min_page_len_; I missed changing this to min_buffer_len_. -- To view, visit http://gerrit.cloudera.org:8080/3993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
