Lars Volker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables ......................................................................
Patch Set 2: Code-Review+1 (3 comments) Thank you for the review. I addressed the comments and will start GVO. http://gerrit.cloudera.org:8080/#/c/4126/1/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test: Line 71: # IMPALA-3776: Create an Avro table, add a column to the Avro schema and make sure > nit: Avro table (Avro is a proper noun) Done Line 77: "namespace": "org.apache.test", > org.apache.test :) Done Line 133: DESCRIBE FORMATTED avro_alter_schema_remove_column; > remove comment, pretty clear that this should not NPE if we have a positive Done -- To view, visit http://gerrit.cloudera.org:8080/4126 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb69d3678e662465d40aee80ba23132ea13871a0 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
