Alex Behm has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/4166/1/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java: Line 359: * Also computes totalBytes_ > , totalFiles_, hasCorruptTableStats_ Done Line 370: if ((cardinality_ < -1) || (cardinality_ == 0 && tbl_.getTotalHdfsBytes() > 0)) { > remove () from (cardinality_ < -1) - i find that easier to read because it Done Line 374: totalFiles_ += partitions_.get(0).getFileDescriptors().size(); > another checkstate that we only have a single partition? Done Line 377: // Nothing to scan. Definitely a cardinality of 0 even if we have no stats. > make this branch the first one to avoid negation Done Line 414: if (!(cardinality_ >= 0 || cardinality_ == -1)) { > a bit easier: if (cardinality_ < -1) Done http://gerrit.cloudera.org:8080/#/c/4166/1/testdata/workloads/functional-planner/queries/PlannerTest/hbase.test File testdata/workloads/functional-planner/queries/PlannerTest/hbase.test: Line 495: 04:HASH JOIN [INNER JOIN] > that generally seems to be the case as often as it is not. :) Turns out my hbase setup was messed up, sorry. Reverted. -- To view, visit http://gerrit.cloudera.org:8080/4166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d3305791d96e1c23a901af7b7c109af9352bb44 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
