Alex Behm has posted comments on this change. Change subject: IMPALA-1654: Partition expr in DDL operations. ......................................................................
Patch Set 1: (4 comments) Doing another pass over the code now. There are still two open questions: - use batch API yes/no - how to deal with NOT EXISTS now http://gerrit.cloudera.org:8080/#/c/3942/1/fe/src/main/java/com/cloudera/impala/analysis/PartitionSet.java File fe/src/main/java/com/cloudera/impala/analysis/PartitionSet.java: Line 93: "Dynamic partition spec is not supported."); > After a second thought, I think we may allow a single slotref in partition Works for me. Line 132: // Transform <COL> = NULL into IsNull expr; <String COL> = '' into IsNull expr and > The old kv style partition spec is case insensitive, and it treats empty st I think the case-sensitivity is a bug that we should just fix. A partition-key value is no different than other data values and strings are generally case sensitive. You can see some more details here IMPALA-4033 (which I filed recently). http://gerrit.cloudera.org:8080/#/c/3942/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1834: } catch (NoSuchObjectException e) { > Hive does this: How does Hive set the minCount? I agree transactional behavior is desirable, but in the absence of facilities for running distributed transactions, I think all we can do is best effort. http://gerrit.cloudera.org:8080/#/c/3942/1/shell/impala_client.py File shell/impala_client.py: Line 450: excluded_query_types = ['use', 'drop'] > I did. Those not returning a result set just return 0 row. I suppose it wor Great! Thank you. -- To view, visit http://gerrit.cloudera.org:8080/3942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-HasComments: Yes
