Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. ......................................................................
Patch Set 11: > From the discussion today: > > Points agreed on: > - Collapse Executors and states, i.e. collapse FragmentInstanceExecutor > into FragmentInstanceState, so that responsibilities and boundaries > of classes are clear. > > - QueryExecMgr is still responsible for setting up the QueryState > and creating the fragment threads for now. Once the per-query RPC > is implemented, the model will change such that QueryExecMgr > creates a “query" thread which sets up the QueryState and starts > the fragment threads. Small correction: once we have the per-query rpc we'll still have QEM create the QueryState and register it before starting the query thread (which then starts the fragment instance threads). > > Additionally, I'll put out a separate patch with *only* headers > that are parallel with the existing headers, so that Lars can use > that to work on the per-query RPC. -- To view, visit http://gerrit.cloudera.org:8080/3817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I892091d6401acb2ea91ccb1623af54c6f9635e6c Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
