Tim Armstrong has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4113/3/be/src/exec/hdfs-scan-node-mt.cc File be/src/exec/hdfs-scan-node-mt.cc: PS3, Line 48: !files.second.empty() > We currently don't have any automated test coverage for the new scan node. I was more wondering how you discovered this and whether we would detect it with our automated tests even after this becomes the default. Line 72: // so we need to tell them there is work to do. > Correct, Added a DCHECK. We don't set scan_range_ to NULL in the ReachedLimit() case, unless I missed something, but we also shouldn't call back into GetNext() if it returned eos. -- To view, visit http://gerrit.cloudera.org:8080/4113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
