Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder ......................................................................
Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/3873/10/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: Line 45: /// The builder owns the hash tables and build row partitions. The builder partitions > Let's follow your suggestion of finishing level0 completely in this builder I did this, although the handoff is done in terms of streams , because it avoids have to add an additional complication to the BufferedTupleStream abstraction. http://gerrit.cloudera.org:8080/#/c/3873/10/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 150: runtime_profile()->AddCodegenStatus( > Shouldn't this be done in builder_->Prepare() or similar? I was mainly aiming to achieve a clean separation in this patch, leaving the remaining plumbing to a follow-up patch once the query/fragment changes are merged. That said, it seems reasonable to move codegen now. This exposed an issue with AddRuntimeExecOption() being tied to ExecNodes that I posted a separate patch for that I'll rebase onto. http://gerrit.cloudera.org:8080/#/c/3873/10/be/src/util/runtime-profile.h File be/src/util/runtime-profile.h: Line 408: /// Time spent in this node (not including the children). Computed in > AddChild() Done -- To view, visit http://gerrit.cloudera.org:8080/3873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e02ea9c7a7d1a0f373b11aa06c3237e1c7bd4cb Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
