Youwei Wang has posted comments on this change. Change subject: Impala-4058: unaligned memory access issue in SIMDed byteswap. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4204/1//COMMIT_MSG Commit Message: Line 9: Substitute the direct memory assignments using _mm_loadu_si128/_mm_storeu_si128 > Please wrap commit comment lines at 72 characters Hi Jim. Thank you for your review. If you don't mind, this patch will be abandoned soon since we are working on a similar one. http://gerrit.cloudera.org:8080/#/c/4204/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1935: TestStringValue("reverse('abcdefghijklmnop')", "ponmlkjihgfedcba"); > I am not sure that these exercise the unaligned loads and stores, or that i Hi Jim. Simply speaking, my idea is to prove the string reverse function can handle such "long" strings using new implementation. And yes, the memory address of these strings are not necessarily aligned or unaligned. So if you think these test cases not necessary to keep, simply abandoning this patch is okay. -- To view, visit http://gerrit.cloudera.org:8080/4204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2986991f8b695d68af465fd0aff293d3d03709a0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
