Hello Jim Apple, Yuanhao Luo, Internal Jenkins, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4209 to review the following change. Change subject: IMPALA-2878: Fix Base64Decode error and remove duplicate codes. ...................................................................... IMPALA-2878: Fix Base64Decode error and remove duplicate codes. Original impala::Base64Decode() method wouldn't return original string if there were trailing '\0'. For example, string "a\0" would be encoded into "YQA=", while calling original Base64Decode() method, the return value is "a", which losts the trailing '\0' of original string "a\0". Besides, this commit remove duplicate codes of function impala::Base64En/Decode() and impala::StringFunctions::Base64En/Decode() Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab Reviewed-on: http://gerrit.cloudera.org:8080/3824 Reviewed-by: Yuanhao Luo <luoyuan...@software.ict.ac.cn> Reviewed-by: Jim Apple <jbap...@cloudera.com> Tested-by: Internal Jenkins (cherry picked from commit a46b731915bbe8c71f4f0ca7aacc839edebcf6c5) --- M be/src/exec/hdfs-table-sink.cc M be/src/exprs/string-functions-ir.cc M be/src/service/impala-http-handler.cc M be/src/util/CMakeLists.txt R be/src/util/coding-util-test.cc R be/src/util/coding-util.cc R be/src/util/coding-util.h M be/src/util/runtime-profile.cc M be/src/util/thread.cc M be/src/util/webserver.cc 10 files changed, 124 insertions(+), 84 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/09/4209/1 -- To view, visit http://gerrit.cloudera.org:8080/4209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0170a7d180ab048d0ff2196a24ddc53626aa7aab Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Yuanhao Luo <luoyuan...@software.ict.ac.cn>