Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts ......................................................................
IMPALA-4006: dangerous rm -rf statements in scripts Quoted variable substitutions in rm -rf commands and in many other places. This prevents disasters if those variables contain whitespace. Redirected output of the cd commands to /dev/null. This prevents polluting the target variable with the directory name when the CDPATH environment variable is set. Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Reviewed-on: http://gerrit.cloudera.org:8080/4078 Tested-by: Internal Jenkins Reviewed-by: Tim Armstrong <[email protected]> --- M bin/clean.sh M bin/impala-config.sh M bin/impala-python M bin/impala-python-common.sh M bin/run-all-tests.sh M bin/set-classpath.sh M buildall.sh M infra/python/deps/download_requirements 8 files changed, 209 insertions(+), 203 deletions(-) Approvals: Internal Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7503794180dee99eeb979e67f34e3b2edade70fe Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yonghyun Hwang <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]>
