Henry Robinson has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4163/4/be/src/service/child-query.h File be/src/service/child-query.h: PS4, Line 193: has not been Join()ed > Are you sure? The comment on Thread::Join() says "Blocks until this thread Sorry, I read the comment as 'true up until Join() is called', not 'true up until Join() completes'. I think it's clear enough as it is. -- To view, visit http://gerrit.cloudera.org:8080/4163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3024803e03595ee69c47759b58e8443d7bd167 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
