Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4301/1//COMMIT_MSG Commit Message: PS1, Line 47: runtime-state-new.h is what runtime-state.h would look like, and is : just a temporary name. Wouldn't we want to kill RuntimeState rather than update it to use the new QueryState/FInstanceState? I'd think that everything in RuntimeState could fit into either QueryState or FInstanceState. That would be really nice, because then the scope of those members is clear (whereas today RuntimeState is a mess of finstance & query state stuff, and even some wrappers around ExecEnv which may not be needed or maybe could just be accessed via QueryState). Sorry if I missed a discussion about this. -- To view, visit http://gerrit.cloudera.org:8080/4301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If58292a5c377660d97e7e7cc0c3122328eba72ed Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
