Alex Behm has posted comments on this change.

Change subject: IMPALA-3491: Use unique database fixture in test_nested_types.py
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4302/1/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:

PS1, Line 22: import random
> Double check me, but I don't believe this import is needed.
You are correct. I cleaned up the imports.


PS1, Line 82:   TESTFILE_DIR = os.environ['IMPALA_HOME'] + 
"/testdata/parquet_nested_types_encodings"
> Use os.path.join to form this directory path.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c56df0c6a5f771222dedb69353f8bebe01d5a90
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: Yes

Reply via email to