Michael Brown has posted comments on this change. Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py ......................................................................
Patch Set 1: Thanks for the patch. My personal preference would be to have a more comprehensive patch that does one of these, in order of preference: 1. Fix underlying cause of IMPALA-4075, in which Impala and Kudu aren't working well together in your dev environment. This should be working, and it isn't. Why not? 2. A more comprehensive strategy to support "KUDU_IS_SUPPORTED=false" scenarios. It's not tenable to inspect the environment variable all over the place. A solution here would be to augment tests/common/environ.py to be a method or variable that reports whether kudu is supported, and fix up the handful of places that inspect the KUDU_IS_SUPPORTED environment variable directly. -- To view, visit http://gerrit.cloudera.org:8080/4312 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd22f1ca10651c86841bc1ed7d108b26e3d16ee9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: hewenting <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: No
