Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3937/4/fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java File fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java: PS4, Line 126: dataSource_ = (ExternalDataSource) ctor.newInstance(); I think this will break compatibility with old data sources, customers will likely have to recompile against the renamed interface. We can address this separately but shouldn't forget. I filed https://issues.cloudera.org/browse/IMPALA-4081 -- To view, visit http://gerrit.cloudera.org:8080/3937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35fa6602a7fc0c212b2ef5e2b3322b77dde7e2 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
