Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3481: Use Kudu ScanToken API for scan ranges ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4120/4/be/src/exec/kudu-scan-node-test.cc File be/src/exec/kudu-scan-node-test.cc: Line 53: class KuduScanNodeTest : public testing::Test { > I can't say since I didn't add these to begin with, but while we're in the good idea, let's leave a todo. the reason i don't like white-box testing is that you end up writing a lot of test harness code, which can have bugs, and you might end up testing paths that aren't taken during actual query execution. http://gerrit.cloudera.org:8080/#/c/4120/4/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: Line 114: if (batch_done) break; > To avoid returning Status::OK() again, and in case logic gets added after t no, please leave as is. http://gerrit.cloudera.org:8080/#/c/4120/4/fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java File fe/src/test/java/com/cloudera/impala/planner/KuduPlannerTest.java: Line 33: public class KuduPlannerTest extends PlannerTestBase { > I don't know what the original reason was, but now that it's separate it's is this very slow? the planner tests typically take something like 40s to run, a few seconds on top won't make a difference. also, it's good to have everything in one place, so i don't need to remember to run two planner tests when making planner changes. -- To view, visit http://gerrit.cloudera.org:8080/4120 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I160e5849d372755748ff5ba3c90a4651c804b220 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
