Alex Behm has posted comments on this change. Change subject: IMPALA-3491: Use unique database fixture in test_insert_parquet.py ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4317/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: PS1, Line 123: i > Minor: Remore trailing "i" Done PS1, Line 128: CREATE > Minor: by PEP-8 style convention, globally-scoped constants get all caps in I'm not super familiar with the PEP-8 convention, so it does help if you point out violations :) Happy to fix at least this file. -- To view, visit http://gerrit.cloudera.org:8080/4317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I790b2ed5236640c7263826d1d2a74b64d43ac6f7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
