Tim Armstrong has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator ......................................................................
Patch Set 3: Turns out the new DCHECKs were incorrect (I must have had a release build running locally when I tested it). Removed them and added a comment explaining the lifetime of the exprs. -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I058917da2c13ba41d6ff7fefbb761606344312ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
