Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report
......................................................................


Patch Set 2:

(1 comment)

Thanks for doing this. 

For context, IMPALA-3090 improved some of the issues that IMPALA-1616 
describes. I also have another change in flight that changes the output of 
these reports somewhat: 
https://gerrit.cloudera.org/#/c/3993/12/be/src/runtime/mem-tracker.cc

http://gerrit.cloudera.org:8080/#/c/4335/2/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS2, Line 250: From
Maybe "by Fragment" ?


-- 
To view, visit http://gerrit.cloudera.org:8080/4335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb4e0c359d889938b4c351771ba539850bdb95ea
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to