Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: reservation implementation for new buffer pool ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool/reservation-tracker.cc File be/src/bufferpool/reservation-tracker.cc: PS10, Line 100: MemLimitExceeded > Having the caller directly use IncreaseReservation() to acquire its initial Done http://gerrit.cloudera.org:8080/#/c/3993/10/be/src/bufferpool/reservation-tracker.h File be/src/bufferpool/reservation-tracker.h: Line 178: int64_t bytes, bool use_existing_reservation, bool is_child_reservation); > yeah, didn't suggest getting rid of the unlocked one cause now the child ac Yeah it doesn't seem ideal either way. I think this reduces the degree of indirection a bit so may be easier to trace. http://gerrit.cloudera.org:8080/#/c/3993/11/be/src/bufferpool/reservation-tracker.h File be/src/bufferpool/reservation-tracker.h: Line 120: /// made to the state of any ReservationTrackers. > formatting glitch Done -- To view, visit http://gerrit.cloudera.org:8080/3993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc89e863efb4cc506657bfdaaaf633a10bbab6 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
