Alex Behm has posted comments on this change. Change subject: IMPALA-4098: Open()/Close() partition exprs once per fragment instance. ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4340/2//COMMIT_MSG Commit Message: Line 10: exec nodes (and/or a data sink) within the same fragment, so the lifecycle > do you mean fragment or fragment instance? please clarify. (and if you real Fragment instance, of course. Fixed. http://gerrit.cloudera.org:8080/#/c/4340/2/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: Line 438: Status PrepareAndOpenExprs(RuntimeState* state) const; > ..PartitionExprs()? (or do you anticipate throwing more exprs into this?) Done. Should definitely not add more exprs in here. -- To view, visit http://gerrit.cloudera.org:8080/4340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id179df645e500530f4418988f6ce64a03d669892 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
