Chen Huang has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/1/be/src/util/blocking-queue.h File be/src/util/blocking-queue.h: PS1, Line 192: /// 'get' callers wait on this. : mutable pthread_cond_t get_cv_; : : /// 'put' callers wait on this. : mutable pthread_cond_t put_cv_; : : /// Guards against concurrent access to 'read_list_'. : mutable pthread_mutex_t read_lock_; : : /// Guards against concurrent access to 'write_list_'. : mutable pthread_mutex_t write_lock_; why do we add 'mutable' here? they are used in non-const member functions anyway -- To view, visit http://gerrit.cloudera.org:8080/4350 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4cf351455efefb0f3bb791cf9bc82d1421d54 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Chen Huang <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
