David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh ......................................................................
Patch Set 3: (3 comments) Thanks for the feedback. It was helpful. Also, note that I'm adding a preliminary check for HDFS. http://gerrit.cloudera.org:8080/#/c/4348/3/testdata/bin/check-hbase-nodes.py File testdata/bin/check-hbase-nodes.py: Line 75: except Exception as e: > Does the message you tack on to the exception give you a lot more informati No, but the exception doesn't give me any addtional helpful information, and I prefer not to look at tracebacks if I don't need to. Purely an aesthetic choice. If you strongly prefer the traceback, I can remove. Line 92: while True: > More readable to put the timeout at the top of the loop and exit if you bug I think you mean "<", yes? ;-) I find the more verbose version more explicit and legible, but eh, not a big deal either way. WRT to 1/0 vs. T/F, I'm actually summing the number of errors at the end. Probably not necessary, but now you can pass in any number of znodes, and see which ones fail and which don't. (It's probably overkill.) Line 103: except Exception: > This is wrong, ignore. Nevertheless, thanks to David for looking into it. F Actually, this was a useful comment, because it prompted me to not be lazy and actually import and check for specific exceptions, which is the right thing to do. -- To view, visit http://gerrit.cloudera.org:8080/4348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b81f3cfb6ea0ba7b18ce5fcd5d268f515c8b0c3 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
