I remember using this tool together with fix_includes and the most annoying issue was that it would remove high-level includes (e.g. boost/unordered_map) and replace them with all the headers from inside that include instead, making it very hard to use.
This would sometimes turn #include <boost/unordered_map.hpp> into ... #include <boost/unordered/detail/equivalent.hpp> #include <boost/unordered/detail/unique.hpp> #include <boost/unordered/detail/util.hpp> ... On Thu, Oct 27, 2016 at 10:08 PM, Alex Behm <[email protected]> wrote: > I recently added a script to run cppclean over the Impala BE: > > https://pypi.python.org/pypi/cppclean > > You can run it in IMPALA_HOME/bin/cppclean.sh > > I don't think cppclean is as sophisticated as include-what-you-see, but it > might be an easy start. > > On Thu, Oct 27, 2016 at 3:59 PM, Jim Apple <[email protected]> wrote: > > > I used it before fix_includes was available. It found a lot of issues, > > but I hated having to fix them. I suspect that it is much, much more > > usable now. > > > > On Thu, Oct 27, 2016 at 3:51 PM, Marcel Kornacker <[email protected]> > > wrote: > > > Does anyone have experience with this tool for analyzing C++ includes? > > > http://include-what-you-use.org/ > > > > > > I have a feeling that our development productivity is somewhat > > > impacted by too-generous includes (instead of forward declarations), > > > and getting some (mechanized) help for cleaning that up would be > > > useful. > > > > > > This would also be a positive newbie contribution. > > >
