Lars Volker has posted comments on this change. Change subject: PREVIEW: IMPALA-4223: Handle truncated file read from HDFS cache ......................................................................
Patch Set 1: (1 comment) > This should probably go in ASF's master branch, then get > cherry-picked. Yes. This has been reviewed and merged into master here: https://gerrit.cloudera.org/#/c/4828/ I will coordinate the backporting efforts in the Jira. http://gerrit.cloudera.org:8080/#/c/4645/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: PS1, Line 438: hadoopRzBufferFree(hdfs_file_->file(), cached_buffer_); : cached_buffer_ = NULL; : // Close file that was opened in Open(). : io_mgr_->CacheOrCloseFileHandle(file(), hdfs_file_, false); : hdfs_file_ = NULL; : stringstream ss; > Can't we just call ScanRange::Close()? Done. -- To view, visit http://gerrit.cloudera.org:8080/4645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
