Should we add to our pre-merge testing (aka GVM, aka GVO) some tests
that don't run impalad, but only build it or check for correctness?

For instance:

1. bin/run_clang_tidy.sh - should we force our code to always be clang-tidy?

2. bin/check-rat-report.py - uses Apache RAT to check that our code
has proper license headers

3. Other buildall.sh options - in the past we have broken -asan,
-release, or -so without breaking the pre-commit test.

4. Docs build

I think I can do these without increasing the end-to-end time it takes
to run the tests, by doing them in parallel. One issue I see is that
committers who see their change as minor and merge it manually,
without pre-merge testing, might break clang-tidy or RAT tests.

Reply via email to