Matthew Jacobs has posted comments on this change.

Change subject: Add CLEAN_AFTER_BUILD option to clean files during build
......................................................................


Patch Set 1:

(2 comments)

Thanks!

http://gerrit.cloudera.org:8080/#/c/5313/1/init.sh
File init.sh:

Line 53: # Clean the complete build
indicate this is before starting building


PS1, Line 60: CLEAN_AFTER_BUILD
it might be worth naming this something that indicates it's cleaning the 
intermediate build files, but I guess INTERMEDIATE is too long. Maybe 
CLEAN_TMP_AFTER_BUILD? Or I guess it's fine as is.


-- 
To view, visit http://gerrit.cloudera.org:8080/5313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I064af33d2719592c9e2fdec3a699b4dad0e869e6
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to