Hi all,

Some of our test names are also prefixes of other tests, e.g.
in tests/metadata/test_ddl.py we have *test_create_table* and
*test_create_table_as_select*. Selecting the former with "impala-py.test -k
test_create_table" will also select the latter.

In the past when I ran into these I renamed the prefix-named test, usually
by adding "_test" to make them unique. However this is somewhat unintuitive
and consequently needed explanation during reviews. To improve the
situation, I would like to propose changing all affected tests in a single
commit.

Before doing that, I'd like to ask for feedback. I created IMPALA-4721
<https://issues.cloudera.org/browse/IMPALA-4721> to track this.

Thanks, Lars

Reply via email to