We're trying to update pytest in the Impala python environment to a more recent version, in order to take advantage of a few bug fixes that have been introduced since our existing version: 2.7.2 (which is going on two years old.)

However, some of our current test code doesn't play nicely with pytest's default auto-discovery mechanism, which is sensitive the names of test modules, classes, and functions -- even ones that are imported from other locations. This is not really a big issue, and it may have been true all along, but later versions of pytest have started to emit explicit warnings about it.

The simple fix was to simply rename some the problematic classes, specifically TestMatrix, TestVector, and TestDimension. These are now called ImpalaTestMatrix, ImpalaTestVector, and ImpalaTestDimension. Of course, all of the test modules have been updated to reflect this as well.

This is just a courtesy message to let you know that this change has been +2'ed and will be cherry-picked soon. If you have in-flight patches right now in which you have added new test modules, classes, etc., these tests may fail until you update your code to use the new names.

The review in question is https://gerrit.cloudera.org/#/c/5794/.

Thanks.
--
David Knupp
Software Engineer
Cloudera
415-312-1049
<https://www.postbox-inc.com/?utm_source=email&utm_medium=siglink&utm_campaign=reach>

Reply via email to