+1 for not compiling the benchmarks in -notests On Mon, Feb 20, 2017 at 7:55 PM, Jim Apple <[email protected]> wrote:
> > On which note, would anyone object if we disabled benchmark compilation > by > > default when building the BE tests? I mean separating out -notests into > > -notests and -build_benchmarks (the latter false by default). > > I think this is a great idea. > > > I don't mind if the benchmarks bitrot as a result, because we don't run > > them regularly or pay attention to their output except when developing a > > feature. Of course, maybe an 'exhaustive' run should build the benchmarks > > as well just to keep us honest, but I'd be happy if 95% of Jenkins builds > > didn't bother. > > The pre-merge (aka GVM aka GVO) testing builds > http://jenkins.impala.io:8080/job/all-build-options, which builds > without the "-notests" flag. >
